Fix console.log() with no arguments not printing newline #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed ArgumentRequirement from Yes to No in logWithLevel so that console.log(), console.debug(), console.info(), console.warn(), and console.error() with no arguments will still call messageWithTypeAndLevel. This allows embedders like Bun to handle the empty argument case and print a newline, matching Node.js and browser behavior. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Member
Author
|
/build-preview |
|
🔄 Preview build started Release tag: |
|
Caution Review failedThe pull request is closed. WalkthroughModified ConsoleClient.cpp's logWithLevel function to change the ArgumentRequirement parameter from Yes to No when calling internalMessageWithTypeAndLevel. This removes the guard preventing logs with zero arguments, allowing console messages without arguments to generate appropriate prefixes. Changes
Possibly related PRs
Suggested reviewers
Comment |
|
This may have been caused by a newer build being triggered for the same PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed ArgumentRequirement from Yes to No in logWithLevel so that console.log(), console.debug(), console.info(), console.warn(), and console.error() with no arguments will still call messageWithTypeAndLevel.
This allows embedders like Bun to handle the empty argument case and print a newline, matching Node.js and browser behavior.