Birmingham | 26-ITP-Jan | Ayodeji Ayorinde | Sprint 1 | Wireframe to Web Code2 #1095
Conversation
Updated index.html file to align with wireframe layout
Updated style.css file to align with wireframe layout
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Ayogit1
added
the
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
I can see a few issues with the HTML, please consider my other comments
| </body> | ||
| </html> | ||
|
|
||
| <!DOCTYPE html> |
There was a problem hiding this comment.
Is this the main html you want to submit? is it in the right place?
|
|
||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> <meta charset="UTF-8"> |
There was a problem hiding this comment.
The formatting here makes it difficult to read. Can you consider using an auto-formatter?
| <div class="text-block"> | ||
| <p>WHAT IS THE PURPOSE OF A README FILE?</p> | ||
| <p>A README file exists to explain what a project is, why it matters, and how to use it. It’s the first place someone looks when they encounter your repository, dataset, or codebase.</p> | ||
| <!-- <p>Line of text number three</p> --> |
There was a problem hiding this comment.
Is this line of code doing anything? If not, it is better to remove it than leave it commented out
| </div> | ||
| <footer> | ||
| <p> | ||
| This is footer information. |
There was a problem hiding this comment.
Could you add some real footer information? Like your github username for example
| <p class="subtitle">This is a sample of wireframe implementation</p> | ||
| </div> | ||
| <div class="text-block"> | ||
| <p>WHAT IS THE PURPOSE OF A README FILE?</p> |
There was a problem hiding this comment.
If you look at the wireframe diagram, there are some big Xs on the picture. Do you know what they represent?
| <p><a class="read-more" href="https://www.w3schools.com/git/git_branch.asp">READ MORE</a></p> | ||
| </div> | ||
| </div> | ||
| <footer> |
There was a problem hiding this comment.
Do you find the footer easy to read as it is right now?
LonMcGregor
added
Reviewed
2 participants
Learners, PR Template
Self checklist
Changelist
My PR contains updated index.html and style.css files, both aligning to wireframe layout