Fix basePath edge-case in registerSound#322
Open
porglezomp wants to merge 1 commit intoCreateJS:masterfrom
Open
Fix basePath edge-case in registerSound#322porglezomp wants to merge 1 commit intoCreateJS:masterfrom
porglezomp wants to merge 1 commit intoCreateJS:masterfrom
Conversation
When calling registerSound with an object for src, like for instance
when handling a data URL with { src: { mp3: ... }, type: "sound" }, the
id would get set as a basePath, and some inconsistent treatment of falsy
values would lead to the id getting prepended to the URL. This fixes
things so that sounds can be registered with data URLs.
pavel1979-lab
approved these changes
May 4, 2020
varyndev
added a commit
to VarynInc/SoundJS
that referenced
this pull request
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling registerSound with an object for src, like for instance when handling a data URL with
{ src: { mp3: ... }, type: "sound" }, the id would get set as abasePath, and some inconsistent treatment of falsy values would lead to the id getting prepended to the URL. This fixes things so that sounds can be registered with data URLs.Fixes #120