Conversation
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
============================================
+ Coverage 79.49% 84.17% +4.67%
- Complexity 188 200 +12
============================================
Files 23 23
Lines 556 556
Branches 60 60
============================================
+ Hits 442 468 +26
+ Misses 91 65 -26
Partials 23 23
Continue to review full report at Codecov.
|
DvirDukhan
reviewed
Nov 8, 2020
| } | ||
|
|
||
| @Test | ||
| public void testExceptions() { |
Contributor
There was a problem hiding this comment.
move this to a different unit test file. break every functionality to test case
Comment on lines
+75
to
+81
| public void testSyntaxErrorReporting() { | ||
| try { | ||
| // Issue a query that causes a compile-time error | ||
| api.query("social", "RETURN toUpper(5)"); | ||
| } catch (Exception e) { | ||
| Assert.assertEquals(JRedisGraphCompileTimeException.class, e.getClass()); | ||
| Assert.assertEquals( "redis.clients.jedis.exceptions.JedisDataException: Type mismatch: expected String but was Integer", e.getMessage()); |
Contributor
There was a problem hiding this comment.
can you use juint 5 for assertThrows?
https://www.baeldung.com/junit-assert-exception
Contributor
Author
There was a problem hiding this comment.
we are not using Junit 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.