feat(bash): add env parameter for setting environment variables #11068
+43
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add optional `env` parameter to the bash tool that allows passing environment variables to the spawned process. This enables plugins to inject environment variables like AGENT_MODE and AGENT_ID to track whether commands are running in primary or subagent sessions. Changes: - Add `env` parameter to bash tool schema (z.record(z.string(), z.string())) - Merge env vars with process.env in spawn call - Add tests for single and multiple environment variables
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Add documentation for the optional env parameter that allows setting environment variables for bash commands.
Contributor
|
This seems like a good idea. I can imagine how the feature could be useful. Have not personally tested yet, but the PR looks pretty clean, LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11065
Adds optional
envparameter to the bash tool that allows plugins to inject environment variables into spawned processes.Changes:
env: z.record(z.string(), z.string()).optional()to bash tool schemaprocess.envin spawn callVerified:
tool.execute.beforehook to set env vars