fix: add missing test workflow files with proper syntax #429
Conversation
Document proven optimization techniques that work within the constraint of keeping React vendor bundle intact (due to initialization issues). Strategies include: - Resource hints for faster connections (100-300ms gain) - Critical CSS inlining (200-500ms gain) - Service Worker caching (2-3s on repeat visits) - Font optimization with font-display: swap - HTTP/2 Server Push via Netlify headers - Modern image formats (AVIF/WebP) - Lazy loading and third-party script deferral Expected improvements: - FCP: 4.1s → 2.0s - LCP: 4.4s → 2.5s - Repeat visits: <1s with caching References production postmortem showing why React bundle splitting causes failures. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
✅ Deploy Preview for contributor-info ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
bot
added
config
🚀 Performance Report📊 Lighthouse Audit✅ Lighthouse tests completed for: 📦 Bundle AnalysisPerformance budget checks completed. See workflow summary for details. 🎯 Core Web Vitals Targets
📈 Next Steps
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic analysis
1 issue found across 2 files • Review in cubic
React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai to give feedback, ask questions, or re-run the review.
.github/workflows/test.yml
Outdated
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '18' |
There was a problem hiding this comment.
'actions/setup-node' is configured to install Node 18 even though the repo declares a minimum Node 20 requirement; this version mismatch can break builds or mask issues that would surface on the required runtime.
Prompt for AI agents
Address the following comment on .github/workflows/test.yml at line 21:
<comment>'actions/setup-node' is configured to install Node 18 even though the repo declares a minimum Node 20 requirement; this version mismatch can break builds or mask issues that would surface on the required runtime.</comment>
<file context>
@@ -0,0 +1,37 @@
+name: Build and Test
+
+on:
+ push:
+ branches: [main]
+ pull_request:
+ branches: [main]
+
+jobs:
</file context>
| node-version: '18' | |
| node-version: '20' |
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like
Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
The test.yml and test-with-supabase.yml workflows showing as broken in GitHub Actions are actually duplicates of the existing build.yml workflow. No changes needed. The broken references in GitHub Actions UI are likely cached from old deleted files and should clear up over time. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
bdougie
force-pushed
the
fix/workflow-syntax-errors
branch
from
7e57dd0 to
450ffbf
Compare
|
Closing this PR. The test.yml and test-with-supabase.yml workflows are duplicates of the existing build.yml workflow which already handles all testing, type checking, and building. The broken references in GitHub Actions are likely cached from old deleted files. |
✅ Bundle Size AnalysisAll chunks within limits See the workflow summary for detailed bundle sizes. |
Summary
Fixed broken test workflows that were showing syntax errors on GitHub Actions.
Problem
Two workflow files were showing their path as name in GitHub Actions, which indicates syntax errors:
.github/workflows/test.yml.github/workflows/test-with-supabase.ymlThese files either didn't exist locally or had syntax issues preventing them from being recognized properly.
Solution
Created properly formatted workflow files with valid YAML syntax:
test.yml
test-with-supabase.yml
Test Plan
npx yaml-lint🤖 Generated with Claude Code