Conversation
- Clearer title and explanation - Package manager agnostic install instructions - Use (code=structural_css_pin_clerk_ui) error code format Co-Authored-By: Claude Opus 4.5 <[email protected]>
Previously, the structural CSS warning only triggered when ClerkProvider
mounted. This adds checking when individual components mount with their
own appearance prop (e.g., <SignIn appearance={...} />).
- Add warnAboutComponentAppearance() for checking component-level appearance
- Add useWarnAboutCustomizationWithoutPinning hook called from AppearanceProvider
- Hook gracefully handles missing context (e.g., in tests)
- Only runs in development mode
Co-Authored-By: Claude Opus 4.5 <[email protected]>
🦋 Changeset detectedLatest commit: fb6cb15 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
📝 WalkthroughWalkthroughIntroduces a development-only structural CSS warning flow: adds hook 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Co-Authored-By: Claude Opus 4.5 <[email protected]>
…owser.js - ui.browser.js: 34KB -> 34.5KB - ui.legacy.browser.js: 72KB -> 73KB Co-Authored-By: Claude Opus 4.5 <[email protected]>
|
!snapshot |
|
Hey @alexcarpenter - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact |
alexcarpenter
left a comment
There was a problem hiding this comment.
outside of the perf review shared in slack, tested in dashboard and working 👍🏼
nikosdouvlis
left a comment
There was a problem hiding this comment.
Nice improvement to the DX here
| }); | ||
|
|
||
| return () => { | ||
| if (typeof cancelIdleCallback === 'function' && typeof handle === 'number') { |
There was a problem hiding this comment.
When requestIdleCallback isn't available, we fall back to setTimeout but the cleanup still calls cancelIdleCallback. Probably fine since the 0ms timeout fires immediately anyway, just wanted to flag it
…utPinning - Use useDeepEqualMemo to stabilize appearance reference, preventing effect re-runs when consumers pass inline objects - Fix cleanup function to properly handle setTimeout fallback when requestIdleCallback is unavailable (Safari < 16.4, Node) - Extract inline regexes to module-level constants to avoid repeated compilation Co-Authored-By: Claude Opus 4.5 <[email protected]>
Description
BEFORE
AFTER
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit
New Features
Tests
Chores