2 - Add real hawk catcher to the svelte playground#142
2 - Add real hawk catcher to the svelte playground#142Reversean wants to merge 1 commit intofeature/svelte-integration-playgroundfrom
Conversation
779f6f4 to
fb8bc3b
Compare
8f7960d to
d5a9048
Compare
fb8bc3b to
ca82ad2
Compare
d5a9048 to
f06a3ad
Compare
ca82ad2 to
70da4c7
Compare
f06a3ad to
344c9d6
Compare
70da4c7 to
5bbf3cf
Compare
344c9d6 to
680141a
Compare
5bbf3cf to
f31904c
Compare
There was a problem hiding this comment.
maybe it should be inside "svelte" package?
/packages
/svelte
/playground
/src
...
There was a problem hiding this comment.
I've tried it first, but it seems some problem with yarn or vite:
If I put playground directory into packages/svelte and define it as workspace (I need it because i need to add dependency on @hawk.so/svelte somehow) yarn workspace @hawk.so/svelte-playground build breaks with an error due to the fact that it does not understand some svelte syntax constructs.
Usually it output something like this:
error during build:
[vite-plugin-svelte:compile] [plugin vite-plugin-svelte:compile] src/routes/+layout.svelte (3:9)
1 | <script lang="ts">
2 | import '../app.css';
3 | import favicon from '$lib/assets/favicon.svg';
^
4 |
5 | let {children} = $props();
which shouldn't happen at all.
It seems that vitePreprocess from @sveltejs/vite-plugin-svelte stopped working in this case, but I still don't understand why.
There was a problem hiding this comment.
I managed to solve the problem by upgrading yarn to the latest version. Now we can place the playground in the sveltekit package directory and build will work correctly.
464765c to
5f0af2a
Compare
5f0af2a to
9190832
Compare
9190832 to
127eb1d
Compare
9f69024 to
b2a5df0
Compare
127eb1d to
d8d44fb
Compare
b2a5df0 to
c191c75
Compare
d8d44fb to
7a1b57e
Compare
7a1b57e to
b20584e
Compare
c191c75 to
962ad7d
Compare
b20584e to
aab2e98
Compare
962ad7d to
0b86664
Compare
Closes #137
Added
HawkCatcherconfiguration in svelte playground.