Add exported miner methods: GetBeneficiary, MaxTerminationFee, InitialPledge #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and InitialPledge across multiple versions.
There was a problem hiding this comment.
Pull request overview
This PR adds missing exported miner methods to enable other actors to call them via the FRC (Filecoin Request for Comment) method interface. The changes align with the builtin actors implementation and address issue #403.
Changes:
- Added
GetBeneficiaryExportedmethod to miner actor versions v10 through v18 - Added
MaxTerminationFeeExportedmethod to miner actor versions v16 through v18 - Added
InitialPledgeExportedmethod to miner actor versions v16 through v18
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| builtin/v18/miner/methods.go | Added GetBeneficiaryExported, MaxTerminationFeeExported, and InitialPledgeExported exported methods |
| builtin/v17/miner/methods.go | Added GetBeneficiaryExported, MaxTerminationFeeExported, and InitialPledgeExported exported methods |
| builtin/v16/miner/methods.go | Added GetBeneficiaryExported, MaxTerminationFeeExported, and InitialPledgeExported exported methods |
| builtin/v15/miner/methods.go | Added GetBeneficiaryExported exported method |
| builtin/v14/miner/methods.go | Added GetBeneficiaryExported exported method |
| builtin/v13/miner/methods.go | Added GetBeneficiaryExported exported method |
| builtin/v12/miner/methods.go | Added GetBeneficiaryExported exported method |
| builtin/v11/miner/methods.go | Added GetBeneficiaryExported exported method |
| builtin/v10/miner/methods.go | Added GetBeneficiaryExported exported method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
@rjan90 could you take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing exported miner methods so other actors can call them.
Adds
GetBeneficiaryExported (V10–V18)andMaxTerminationFeeExported+InitialPledgeExported (V16–V18).Closes #403