Fix code scanning alert no. 1: Prototype-polluting function #711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
| // So any property in the target that is not in the source is not treated as a deletion | ||
| for (const key in source) { | ||
| // Skip prototype pollution properties | ||
| if (key === "__proto__" || key === "constructor") { |
There was a problem hiding this comment.
The check for prototype pollution properties is correct, but it should also include 'prototype' to ensure comprehensive protection against prototype pollution attacks.
Suggested change
| if (key === "__proto__" || key === "constructor") { | |
| if (key === "__proto__" || key === "constructor" || key === "prototype") { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/github/safe-settings/security/code-scanning/1
To fix the prototype pollution issue, we need to ensure that properties like
__proto__andconstructorare not copied from thesourceobject to theadditionsobject. This can be achieved by adding a check to skip these properties during the merge process.compareDeepfunction to include a check that skips the__proto__andconstructorproperties.lib/mergeDeep.jsfile, specifically in the loop that iterates over thesourceobject's properties.Suggested fixes powered by Copilot Autofix. Review carefully before merging.