Open
Conversation
This unifies outdated dependency processing. All behaviors should be the same, except for one edge case. If there is only one dependency, the display will be the same as `single`. I'm not sure if that's an issue or not. Assuming that the current UI is not meant to be programmatically accessed it should be fine.
Printed tables are hard to use programmatically. This change will enable the ability to output the task as serialized json.
Showing the previous `single` view any time there was one dependency broke a test, so I reverted the change and now pass args to be able to detect if a single app was requested or not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This supports passing a
--jsonflag tomix hex.outdatedfor programmatic use.In order to make the change a bit easier, I separated out 3 things. Previously, the task was laid out as a
singlevsallformat, where both versions dealt with similar logic.I split them in to three pieces.
process_lockfile-> This basically formats all the dependencies into a tuple{package, lock_version, latest_version, requirements, outdated?}display_outdated-> This structures the view layer--either as a table (existing logic), or as json.set_exit_code-> This sets the exit code based on whether things are outdated, and whether or not certain opts have been passed.