Skip to content

Operators#147

Open
Gabitzzz wants to merge 13 commits intojavascript-tutorial:masterfrom
Gabitzzz:master
Open

Operators#147
Gabitzzz wants to merge 13 commits intojavascript-tutorial:masterfrom
Gabitzzz:master

Conversation

@Gabitzzz
Copy link
Contributor

@Gabitzzz Gabitzzz commented Nov 28, 2022

No description provided.

@javascript-translate-bot javascript-translate-bot requested a review from a team November 28, 2022 03:50
bogdanbacosca
bogdanbacosca requested changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@bogdanbacosca bogdanbacosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mai avem câteva completări de făcut înainte să lipim acest PR cu main branch.
În cea mai mare parte trebuiesc adăugate diacritice la toate mențiunile (în alte părți dacă este necesar) și rescrise cuvintele greșite.
Foarte important Trebuiesc verificate liniile să se potrivească 1 la 1 cu originalul, să nu fie linii șterse sau adăugate în plus.

Almost there.

1-js/02-first-steps/08-operators/4-fix-prompt/solution.md
@@ -1,32 +1,31 @@
The reason is that prompt returns user input as a string.

Copy link
Contributor

@bogdanbacosca bogdanbacosca Nov 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

După instrucțiuni, trebuie să păstrăm liniile "așa cum sunt". Acest lucru reduce conflictele de merge.
Sugestie: adaugă o linie goală între linia 1 și 2.

@javascript-translate-bot
Copy link

javascript-translate-bot commented Nov 28, 2022

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Gabitzzz and others added 8 commits November 28, 2022 13:05
@Gabitzzz @bogdanbacosca
Update 1-js/02-first-steps/08-operators/4-fix-prompt/solution.md
7fcf68d 
Co-authored-by: Bogdan Bacosca <[email protected]>
@Gabitzzz @bogdanbacosca
Update 1-js/02-first-steps/08-operators/4-fix-prompt/solution.md
3187282 
Co-authored-by: Bogdan Bacosca <[email protected]>
@Gabitzzz @bogdanbacosca
Update 1-js/02-first-steps/08-operators/4-fix-prompt/task.md
ded9060 
Co-authored-by: Bogdan Bacosca <[email protected]>
@Gabitzzz @bogdanbacosca
Update 1-js/02-first-steps/08-operators/article.md
2720578 
Co-authored-by: Bogdan Bacosca <[email protected]>
@Gabitzzz @bogdanbacosca
Update 1-js/02-first-steps/08-operators/article.md
4ff45cc 
Co-authored-by: Bogdan Bacosca <[email protected]>
@Gabitzzz @bogdanbacosca
Update 1-js/02-first-steps/08-operators/article.md
41866b9 
Co-authored-by: Bogdan Bacosca <[email protected]>
@Gabitzzz @bogdanbacosca
Update 1-js/02-first-steps/08-operators/4-fix-prompt/task.md
bc536b9 
Co-authored-by: Bogdan Bacosca <[email protected]>
@Gabitzzz @bogdanbacosca
Update 1-js/02-first-steps/08-operators/article.md
2d28aa6 
Co-authored-by: Bogdan Bacosca <[email protected]>
bogdanbacosca
bogdanbacosca requested changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@bogdanbacosca bogdanbacosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conversațiile trebuie adresate.

@javascript-translate-bot
Copy link

javascript-translate-bot commented Jan 25, 2023

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bogdanbacosca bogdanbacosca bogdanbacosca requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

changes requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Gabitzzz @javascript-translate-bot @bogdanbacosca