Skip to content

Conversation

@jakebailey
Copy link
Member

This is a massive PR in prep for deprecating ES5 and making "the current year" be the default target (#62196, #62198).

It does these things:

  • All tests that had been getting an implied target from module now explicitly set @target to es2022, es2023, etc.
  • All tests which explicitly tested es5 now test es5, es2015. In corsa, we can simply skip @target: es5 tests (which will get a deprecation error), but retain coverage.
  • All tests that didn't have @target are assumed to "not care", and now have @target: es2015, such that they will not gain a deprecation error.
  • All tests which don't explicitly set @module but got it from the default target (ES5 -> commonjs) and either see new errors with module=es2015 or "appear" to really be testing something module-related (by way of a lot of LLM classification) now say @module: commonjs to avoid stopping testing them.

This should mean that when the default changes, we see no new errors, and only emit changes in tests which do not care.

Copilot AI review requested due to automatic review settings January 29, 2026 20:45
@github-project-automation github-project-automation bot moved this to Not started in PR Backlog Jan 29, 2026
@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jan 29, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates TypeScript test baselines to prepare for changing the default target away from ES5 by making previously implicit targets explicit and aligning outputs with the intended target/module defaults.

Changes:

  • Regenerates baselines for many conformance tests to reflect explicit @target behavior (including ES5+ES2015 coverage where applicable).
  • Updates numerous emitted .js reference baselines to ES2015+ syntax (classes, for..of, arrows) where tests now target ES2015.
  • Refreshes API sample baselines to use modern JS constructs (const, arrows, template strings) consistent with newer targets.

Reviewed changes

Copilot reviewed 180 out of 22850 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tests/baselines/reference/ES5SymbolType1(target=es5).js Adds/updates baseline for ES5 symbol typing scenario.
tests/baselines/reference/ES5SymbolProperty7(target=es5).types Updates type baseline for ES5 target variant.
tests/baselines/reference/ES5SymbolProperty7(target=es5).symbols Updates symbol baseline for ES5 target variant.
tests/baselines/reference/ES5SymbolProperty7(target=es5).errors.txt Adds/updates error baseline for ES5 target variant.
tests/baselines/reference/ES5SymbolProperty7(target=es2015).js Adds/updates emit baseline for ES2015 target variant.
tests/baselines/reference/ES5SymbolProperty6(target=es5).types Updates type baseline for ES5 target variant.
tests/baselines/reference/ES5SymbolProperty6(target=es5).symbols Updates symbol baseline for ES5 target variant.
tests/baselines/reference/ES5SymbolProperty6(target=es2015).js Adds/updates emit baseline for ES2015 target variant.
tests/baselines/reference/ES5SymbolProperty5(target=es5).types Updates type baseline for ES5 target variant.
tests/baselines/reference/ES5SymbolProperty5(target=es5).symbols Updates symbol baseline for ES5 target variant.
tests/baselines/reference/ES5SymbolProperty5(target=es5).errors.txt Adds/updates error baseline for ES5 target variant.
tests/baselines/reference/ES5SymbolProperty5(target=es2015).js Adds/updates emit baseline for ES2015 target variant.
tests/baselines/reference/ES5SymbolProperty4(target=es5).types Updates type baseline for ES5 target variant.
tests/baselines/reference/ES5SymbolProperty4(target=es5).symbols Updates symbol baseline for ES5 target variant.
tests/baselines/reference/ES5SymbolProperty4(target=es5).errors.txt Adds/updates error baseline for ES5 target variant.
tests/baselines/reference/ES5SymbolProperty4(target=es2015).js Adds/updates emit baseline for ES2015 target variant.
tests/baselines/reference/ES5SymbolProperty3(target=es5).types Updates type baseline for ES5 target variant.
tests/baselines/reference/ES5SymbolProperty3(target=es5).symbols Updates symbol baseline for ES5 target variant.
tests/baselines/reference/ES5SymbolProperty3(target=es5).errors.txt Adds/updates error baseline for ES5 target variant.
tests/baselines/reference/ES5SymbolProperty3(target=es2015).js Adds/updates emit baseline for ES2015 target variant.
tests/baselines/reference/ES5SymbolProperty2(target=es5).types Updates type baseline for ES5 target variant.
tests/baselines/reference/ES5SymbolProperty2(target=es5).symbols Updates symbol baseline for ES5 target variant.
tests/baselines/reference/ES5SymbolProperty2(target=es2015).js Adds/updates emit baseline for ES2015 target variant.
tests/baselines/reference/ES5SymbolProperty1(target=es5).types Updates type baseline for ES5 target variant.
tests/baselines/reference/ES5SymbolProperty1(target=es5).symbols Updates symbol baseline for ES5 target variant.
tests/baselines/reference/ES5SymbolProperty1(target=es2015).js Adds/updates emit baseline for ES2015 target variant.
tests/baselines/reference/ES5For-ofTypeCheck9(target=es5).symbols Updates symbol baseline for ES5 target variant.
tests/baselines/reference/ES5For-ofTypeCheck9(target=es2015).types Adds/updates type baseline for ES2015 target variant.
tests/baselines/reference/ES5For-ofTypeCheck9(target=es2015).js Adds/updates emit baseline for ES2015 target variant.
tests/baselines/reference/ES5For-ofTypeCheck9(target=es2015).errors.txt Adds/updates error baseline for ES2015 target variant.
tests/baselines/reference/ES5For-ofTypeCheck8(target=es5).types Updates type baseline for ES5 target variant.
tests/baselines/reference/ES5For-ofTypeCheck8(target=es5).symbols Updates symbol baseline for ES5 target variant.
tests/baselines/reference/ES5For-ofTypeCheck8(target=es5).errors.txt Adds/updates error baseline for ES5 target variant.
tests/baselines/reference/ES5For-ofTypeCheck8(target=es2015).js Adds/updates emit baseline for ES2015 target variant.
tests/baselines/reference/ES5For-ofTypeCheck7(target=es5).symbols Updates symbol baseline for ES5 target variant.
tests/baselines/reference/ES5For-ofTypeCheck7(target=es2015).types Adds/updates type baseline for ES2015 target variant.
tests/baselines/reference/ES5For-ofTypeCheck7(target=es2015).js Adds/updates emit baseline for ES2015 target variant.
tests/baselines/reference/ES5For-ofTypeCheck7(target=es2015).errors.txt Adds/updates error baseline for ES2015 target variant.
tests/baselines/reference/ES5For-ofTypeCheck6(target=es5).types Updates type baseline for ES5 target variant.
tests/baselines/reference/ES5For-ofTypeCheck6(target=es5).symbols Updates symbol baseline for ES5 target variant.
tests/baselines/reference/ES5For-ofTypeCheck6(target=es2015).js Adds/updates emit baseline for ES2015 target variant.
tests/baselines/reference/ES5For-ofTypeCheck5(target=es5).types Updates type baseline for ES5 target variant.
tests/baselines/reference/ES5For-ofTypeCheck5(target=es5).symbols Updates symbol baseline for ES5 target variant.
tests/baselines/reference/ES5For-ofTypeCheck5(target=es2015).js Adds/updates emit baseline for ES2015 target variant.
tests/baselines/reference/ES5For-ofTypeCheck4(target=es5).types Updates type baseline for ES5 target variant.
tests/baselines/reference/ES5For-ofTypeCheck4(target=es5).symbols Updates symbol baseline for ES5 target variant.
tests/baselines/reference/ES5For-ofTypeCheck4(target=es2015).js Adds/updates emit baseline for ES2015 target variant.
tests/baselines/reference/ES5For-ofTypeCheck3(target=es5).types Updates type baseline for ES5 target variant.
tests/baselines/reference/ES5For-ofTypeCheck3(target=es5).symbols Updates symbol baseline for ES5 target variant.
tests/baselines/reference/ES5For-ofTypeCheck3(target=es2015).js Adds/updates emit baseline for ES2015 target variant.
tests/baselines/reference/ES5For-ofTypeCheck2(target=es5).types Updates type baseline for ES5 target variant.
tests/baselines/reference/ES5For-ofTypeCheck2(target=es5).symbols Updates symbol baseline for ES5 target variant.
tests/baselines/reference/ES5For-ofTypeCheck2(target=es2015).js Adds/updates emit baseline for ES2015 target variant.
tests/baselines/reference/ES5For-ofTypeCheck14(target=es5).symbols Updates symbol baseline for ES5 target variant.
tests/baselines/reference/ES5For-ofTypeCheck14(target=es2015).types Adds/updates type baseline for ES2015 target variant.
tests/baselines/reference/ES5For-ofTypeCheck14(target=es2015).js Adds/updates emit baseline for ES2015 target variant.
tests/baselines/reference/ES5For-ofTypeCheck13(target=es5).symbols Updates symbol baseline for ES5 target variant.
tests/baselines/reference/ES5For-ofTypeCheck13(target=es2015).types Adds/updates type baseline for ES2015 target variant.
tests/baselines/reference/ES5For-ofTypeCheck13(target=es2015).js Adds/updates emit baseline for ES2015 target variant.
tests/baselines/reference/ES5For-ofTypeCheck12(target=es5).types Updates type baseline for ES5 target variant.
tests/baselines/reference/ES5For-ofTypeCheck12(target=es5).symbols Updates symbol baseline for ES5 target variant.
tests/baselines/reference/ES5For-ofTypeCheck12(target=es2015).js Adds/updates emit baseline for ES2015 target variant.
tests/baselines/reference/ES5For-ofTypeCheck12(target=es2015).errors.txt Adds/updates error baseline for ES2015 target variant.
tests/baselines/reference/ES5For-ofTypeCheck11(target=es5).types Updates type baseline for ES5 target variant.
tests/baselines/reference/ES5For-ofTypeCheck11(target=es5).symbols Updates symbol baseline for ES5 target variant.
tests/baselines/reference/ES5For-ofTypeCheck11(target=es5).errors.txt Adds/updates error baseline for ES5 target variant.
tests/baselines/reference/ES5For-ofTypeCheck11(target=es2015).js Adds/updates emit baseline for ES2015 target variant.
tests/baselines/reference/ES5For-ofTypeCheck10(target=es5).symbols Updates symbol baseline for ES5 target variant.
tests/baselines/reference/ES5For-ofTypeCheck10(target=es2015).types Adds/updates type baseline for ES2015 target variant.
tests/baselines/reference/ES5For-ofTypeCheck10(target=es2015).js Adds/updates emit baseline for ES2015 target variant.
tests/baselines/reference/ES5For-ofTypeCheck1(target=es5).types Updates type baseline for ES5 target variant.
tests/baselines/reference/ES5For-ofTypeCheck1(target=es5).symbols Updates symbol baseline for ES5 target variant.
tests/baselines/reference/ES5For-ofTypeCheck1(target=es2015).js Adds/updates emit baseline for ES2015 target variant.
tests/baselines/reference/ES5For-of9.js Updates emit baseline reflecting ES2015+ output.
tests/baselines/reference/ES5For-of8.sourcemap.txt Updates sourcemap baseline reflecting ES2015+ emit.
tests/baselines/reference/ES5For-of8.js Updates emit baseline reflecting ES2015+ output.
tests/baselines/reference/ES5For-of7.js Updates emit baseline reflecting ES2015+ output.
tests/baselines/reference/ES5For-of6.js Updates emit baseline reflecting ES2015+ output.
tests/baselines/reference/ES5For-of5.js Updates emit baseline reflecting ES2015+ output.
tests/baselines/reference/ES5For-of4.js Updates emit baseline reflecting ES2015+ output.
tests/baselines/reference/ES5For-of37.js Updates emit baseline reflecting ES2015+ output.
tests/baselines/reference/ES5For-of36(target=es5).types Adds/updates type baseline for ES5 target variant.
tests/baselines/reference/ES5For-of36(target=es5).symbols Adds/updates symbol baseline for ES5 target variant.
tests/baselines/reference/ES5For-of36(target=es2015).sourcemap.txt Adds/updates sourcemap baseline for ES2015 target variant.
tests/baselines/reference/ES5For-of36(target=es2015).js Adds/updates emit baseline for ES2015 target variant.
tests/baselines/reference/ES5For-of36(target=es2015).errors.txt Adds/updates error baseline for ES2015 target variant.
tests/baselines/reference/ES5For-of35.sourcemap.txt Updates sourcemap baseline reflecting ES2015+ emit.
tests/baselines/reference/ES5For-of35.js Updates emit baseline reflecting ES2015+ output.
tests/baselines/reference/ES5For-of34.sourcemap.txt Updates sourcemap baseline reflecting ES2015+ emit.
tests/baselines/reference/ES5For-of34.js Updates emit baseline reflecting ES2015+ output.
tests/baselines/reference/ES5For-of33.sourcemap.txt Updates sourcemap baseline reflecting ES2015+ emit.
tests/baselines/reference/ES5For-of33.js Updates emit baseline reflecting ES2015+ output.
tests/baselines/reference/ES5For-of31.js Updates emit baseline reflecting ES2015+ output.
tests/baselines/reference/ES5For-of30(target=es5).types Adds/updates type baseline for ES5 target variant.
tests/baselines/reference/ES5For-of30(target=es5).symbols Adds/updates symbol baseline for ES5 target variant.
tests/baselines/reference/ES5For-of30(target=es2015).js Adds/updates emit baseline for ES2015 target variant.
tests/baselines/reference/ES5For-of30(target=es2015).errors.txt Adds/updates error baseline for ES2015 target variant.
tests/baselines/reference/ES5For-of3.sourcemap.txt Updates sourcemap baseline reflecting ES2015+ emit.
tests/baselines/reference/ES5For-of3.js Updates emit baseline reflecting ES2015+ output.
tests/baselines/reference/ES5For-of29.js Updates emit baseline reflecting ES2015+ output.
tests/baselines/reference/ES5For-of28(target=es5).types Adds/updates type baseline for ES5 target variant.
tests/baselines/reference/ES5For-of28(target=es5).symbols Adds/updates symbol baseline for ES5 target variant.
tests/baselines/reference/ES5For-of28(target=es2015).js Adds/updates emit baseline for ES2015 target variant.
tests/baselines/reference/ES5For-of28(target=es2015).errors.txt Adds/updates error baseline for ES2015 target variant.
tests/baselines/reference/ES5For-of27.js Updates emit baseline reflecting ES2015+ output.
tests/baselines/reference/ES5For-of26(target=es5).types Adds/updates type baseline for ES5 target variant.
tests/baselines/reference/ES5For-of26(target=es5).symbols Adds/updates symbol baseline for ES5 target variant.
tests/baselines/reference/ES5For-of26(target=es2015).sourcemap.txt Adds/updates sourcemap baseline for ES2015 target variant.
tests/baselines/reference/ES5For-of26(target=es2015).js Adds/updates emit baseline for ES2015 target variant.
tests/baselines/reference/ES5For-of26(target=es2015).errors.txt Adds/updates error baseline for ES2015 target variant.
tests/baselines/reference/ES5For-of25.sourcemap.txt Updates sourcemap baseline reflecting ES2015+ emit.
tests/baselines/reference/ES5For-of25.js Updates emit baseline reflecting ES2015+ output.
tests/baselines/reference/ES5For-of24.js Updates emit baseline reflecting ES2015+ output.
tests/baselines/reference/ES5For-of23.js Updates emit baseline reflecting ES2015+ output.
tests/baselines/reference/ES5For-of22.js Updates emit baseline reflecting ES2015+ output.
tests/baselines/reference/ES5For-of21.js Updates emit baseline reflecting ES2015+ output.
tests/baselines/reference/ES5For-of20.js Updates emit baseline reflecting ES2015+ output.
tests/baselines/reference/ES5For-of2.js Updates emit baseline reflecting ES2015+ output.
tests/baselines/reference/ES5For-of19.js Updates emit baseline reflecting ES2015+ output.
tests/baselines/reference/ES5For-of18.js Updates emit baseline reflecting ES2015+ output.
tests/baselines/reference/ES5For-of17.js Updates emit baseline reflecting ES2015+ output.
tests/baselines/reference/ES5For-of16.js Updates emit baseline reflecting ES2015+ output.
tests/baselines/reference/ES5For-of15.js Updates emit baseline reflecting ES2015+ output.
tests/baselines/reference/ES5For-of14.js Updates emit baseline reflecting ES2015+ output.
tests/baselines/reference/ES5For-of13.sourcemap.txt Updates sourcemap baseline reflecting ES2015+ emit.
tests/baselines/reference/ES5For-of13.js Updates emit baseline reflecting ES2015+ output.
tests/baselines/reference/ES5For-of12.js Updates emit baseline reflecting ES2015+ output.
tests/baselines/reference/ES5For-of11.js Updates emit baseline reflecting ES2015+ output.
tests/baselines/reference/ES5For-of10.js Updates emit baseline reflecting ES2015+ output.
tests/baselines/reference/ES5For-of1.sourcemap.txt Updates sourcemap baseline reflecting ES2015+ emit.
tests/baselines/reference/ES5For-of1.js Updates emit baseline reflecting ES2015+ output.
tests/baselines/reference/ES3For-ofTypeCheck6(target=es5).types Adds/updates type baseline for ES5 target variant.
tests/baselines/reference/ES3For-ofTypeCheck6(target=es5).symbols Adds/updates symbol baseline for ES5 target variant.
tests/baselines/reference/ES3For-ofTypeCheck6(target=es2015).js Adds/updates emit baseline for ES2015 target variant.
tests/baselines/reference/ES3For-ofTypeCheck4(target=es5).types Adds/updates type baseline for ES5 target variant.
tests/baselines/reference/ES3For-ofTypeCheck4(target=es5).symbols Adds/updates symbol baseline for ES5 target variant.
tests/baselines/reference/ES3For-ofTypeCheck4(target=es2015).js Adds/updates emit baseline for ES2015 target variant.
tests/baselines/reference/ES3For-ofTypeCheck2(target=es5).types Adds/updates type baseline for ES5 target variant.
tests/baselines/reference/ES3For-ofTypeCheck2(target=es5).symbols Adds/updates symbol baseline for ES5 target variant.
tests/baselines/reference/ES3For-ofTypeCheck2(target=es2015).js Adds/updates emit baseline for ES2015 target variant.
tests/baselines/reference/ES3For-ofTypeCheck1(target=es5).types Adds/updates type baseline for ES5 target variant.
tests/baselines/reference/ES3For-ofTypeCheck1(target=es5).symbols Adds/updates symbol baseline for ES5 target variant.
tests/baselines/reference/ES3For-ofTypeCheck1(target=es2015).js Adds/updates emit baseline for ES2015 target variant.
tests/baselines/reference/ClassDeclarationWithInvalidConstOnPropertyDeclaration2.js Updates class emit baseline for ES2015+ target.
tests/baselines/reference/ClassDeclarationWithInvalidConstOnPropertyDeclaration.js Updates class emit baseline for ES2015+ target.
tests/baselines/reference/ClassDeclaration9.js Updates class emit baseline for ES2015+ target.
tests/baselines/reference/ClassDeclaration8.js Updates class emit baseline for ES2015+ target.
tests/baselines/reference/ClassDeclaration26.js Updates class emit baseline for ES2015+ target.
tests/baselines/reference/ClassDeclaration25.js Updates class emit baseline for ES2015+ target.
tests/baselines/reference/ClassDeclaration24.js Updates class emit baseline for ES2015+ target.
tests/baselines/reference/ClassDeclaration22.js Updates class emit baseline for ES2015+ target.
tests/baselines/reference/ClassDeclaration21.js Updates class emit baseline for ES2015+ target.
tests/baselines/reference/ClassDeclaration15.js Updates class emit baseline for ES2015+ target.
tests/baselines/reference/ClassDeclaration14.js Updates class emit baseline for ES2015+ target.
tests/baselines/reference/ClassDeclaration13.js Updates class emit baseline for ES2015+ target.
tests/baselines/reference/ClassDeclaration11.js Updates class emit baseline for ES2015+ target.
tests/baselines/reference/ClassDeclaration10.js Updates class emit baseline for ES2015+ target.
tests/baselines/reference/ClassAndModuleWithSameNameAndCommonRoot.js Updates merged class/module emit baseline for ES2015+ target.
tests/baselines/reference/ClassAndModuleThatMergeWithStaticVariableAndNonExportedVarThatShareAName.js Updates merged emit baseline for ES2015+ target.
tests/baselines/reference/ClassAndModuleThatMergeWithStaticVariableAndExportedVarThatShareAName.js Updates merged emit baseline for ES2015+ target.
tests/baselines/reference/ClassAndModuleThatMergeWithStaticFunctionAndNonExportedFunctionThatShareAName.js Updates merged emit baseline for ES2015+ target.
tests/baselines/reference/ClassAndModuleThatMergeWithStaticFunctionAndExportedFunctionThatShareAName.js Updates merged emit baseline for ES2015+ target.
tests/baselines/reference/ClassAndModuleThatMergeWithModulesExportedStaticFunctionUsingClassPrivateStatics.js Updates merged emit baseline for ES2015+ target.
tests/baselines/reference/ClassAndModuleThatMergeWithModulesExportedGenericFunctionAndNonGenericClassStaticFunctionOfTheSameName.js Updates merged emit baseline for ES2015+ target.
tests/baselines/reference/ClassAndModuleThatMergeWithModulesExportedGenericFunctionAndGenericClassStaticFunctionOfTheSameName.js Updates merged emit baseline for ES2015+ target.
tests/baselines/reference/ClassAndModuleThatMergeWithModuleMemberThatUsesClassTypeParameter.js Updates merged emit baseline for ES2015+ target.
tests/baselines/reference/ArrowFunctionExpression1.js Updates arrow emit baseline for ES2015+ target.
tests/baselines/reference/ArrowFunction4.js Updates arrow emit baseline for ES2015+ target.
tests/baselines/reference/ArrowFunction1.js Updates arrow emit baseline for ES2015+ target.
tests/baselines/reference/AmbientModuleAndNonAmbientClassWithSameNameAndCommonRoot.js Updates merged emit baseline for ES2015+ target.
tests/baselines/reference/APISample_watcher.js Updates API sample emit baseline for ES2015+ target.
tests/baselines/reference/APISample_transform.js Updates API sample emit baseline for ES2015+ target.
tests/baselines/reference/APISample_parseConfig.js Updates API sample emit baseline for ES2015+ target.
tests/baselines/reference/APISample_linter.js Updates API sample emit baseline for ES2015+ target.
tests/baselines/reference/APISample_jsdoc.js Updates API sample emit baseline for ES2015+ target.
tests/baselines/reference/APISample_compile.js Updates API sample emit baseline for ES2015+ target.
tests/baselines/reference/APISample_WatchWithOwnWatchHost.js Updates API sample emit baseline for ES2015+ target.
tests/baselines/reference/APISample_WatchWithDefaults.js Updates API sample emit baseline for ES2015+ target.
tests/baselines/reference/APISample_Watch.js Updates API sample emit baseline for ES2015+ target.
tests/baselines/reference/2dArrays.js Updates sample emit baseline for ES2015+ target.

@jakebailey jakebailey changed the title Set target for tests with implied target from module Update tests in prep for ES5 deprecation, target default change Jan 29, 2026
@github-project-automation github-project-automation bot moved this from Not started to Needs merge in PR Backlog Jan 29, 2026
@jakebailey jakebailey added this pull request to the merge queue Jan 29, 2026
Merged via the queue into microsoft:main with commit 3fc1f26 Jan 29, 2026
33 checks passed
@jakebailey jakebailey deleted the es-current-year-prep branch January 29, 2026 22:49
@github-project-automation github-project-automation bot moved this from Needs merge to Done in PR Backlog Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants