dpdk: mtu flag hotfix #4247
dpdk: mtu flag hotfix #4247
Conversation
testpmd is apparently sensitive to the order of some flags. fixes an issue where the txpkt flag could be ignored.
paxue
left a comment
paxue
left a comment
There was a problem hiding this comment.
I don't see any difference in this commit. Just added a comment, please double check
It's subtle; the order of the flags being passed to the application has changed. In this application the mbuf-size flag needs to be passed before the others, or their values will be ignored. |
Please add a comment for reason in the code for this change, otherwise we don't know why we need to change the order. |
paxue
left a comment
paxue
left a comment
There was a problem hiding this comment.
add the comment for reason why we need to change the order
| f" --max-pkt-len={mtu} --txpkts={mtu} --tx-offloads=0x00008000" | ||
| f" --mbuf-size={mbuf_size}" | ||
| f" --max-pkt-len={mtu} --txpkts={mtu} " | ||
| "--tx-offloads=0x00008000" # enable multi-segment tx offload |
There was a problem hiding this comment.
add comments for this magic value
testpmd is apparently sensitive to the order of some flags. fixes an issue where the txpkt flag could be ignored.