chore(deps): Bump shakapacker from 8.4.0 to 9.5.0 in the npm_and_yarn group across 1 directory#3220
Conversation
Bumps the npm_and_yarn group with 1 update in the / directory: [shakapacker](https://github.com/shakacode/shakapacker). Updates `shakapacker` from 8.4.0 to 9.5.0 - [Changelog](https://github.com/shakacode/shakapacker/blob/main/CHANGELOG.md) - [Commits](shakacode/shakapacker@v8.4.0...v9.5.0) --- updated-dependencies: - dependency-name: shakapacker dependency-version: 9.5.0 dependency-type: direct:production dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <[email protected]>
| "sass": "^1.94.2", | ||
| "sass-loader": "^16.0.6", | ||
| "shakapacker": "8.4.0", | ||
| "shakapacker": "9.5.0", |
There was a problem hiding this comment.
Bug: The shakapacker npm package is updated to 9.5.0 but the corresponding Ruby gem remains at 8.4.0. These versions must be identical to prevent build failures.
Severity: CRITICAL
🔍 Detailed Analysis
The shakapacker npm package is updated to version 9.5.0 in package.json, but the corresponding Ruby gem in the Gemfile remains at 8.4.0. Shakapacker requires exact version matching between its npm package and Ruby gem. The major version bump from 8.x to 9.x includes breaking API changes. This mismatch will cause the rake assets:precompile task, which runs in CI, to fail because the Ruby gem (v8.4.0) will attempt to use APIs that have changed or been removed in the npm package (v9.5.0).
💡 Suggested Fix
Update the shakapacker gem version in the Gemfile to match the npm package version: gem 'shakapacker', '9.5.0'. Then, run bundle update shakapacker to update the Gemfile.lock.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: package.json#L44
Potential issue: The `shakapacker` npm package is updated to version `9.5.0` in
`package.json`, but the corresponding Ruby gem in the `Gemfile` remains at `8.4.0`.
Shakapacker requires exact version matching between its npm package and Ruby gem. The
major version bump from 8.x to 9.x includes breaking API changes. This mismatch will
cause the `rake assets:precompile` task, which runs in CI, to fail because the Ruby gem
(v8.4.0) will attempt to use APIs that have changed or been removed in the npm package
(v9.5.0).
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 8365213
Bumps the npm_and_yarn group with 1 update in the / directory: shakapacker.
Updates
shakapackerfrom 8.4.0 to 9.5.0Changelog
Sourced from shakapacker's changelog.
... (truncated)
Commits
594c561Release 9.5.06e89a7aAdd npm auth pre-flight check to release script (#862)ea4f9e8Update CHANGELOG for v9.5.0 release (#861)3074164Fix gemspec's files regexp to exclude Gemfile.lock (#856)3e06781fix(security): prevent environment variable leak via EnvironmentPlugin (#857)86de096Fix CI failures: restore root bin/shakapacker-config and fix prettier (#858)2d74b61Improve test assertions using explicit have_received checks (#854)5c89f18Update CHANGELOG for v9.4.0 release (#851)32c6adfImprove SHAKAPACKER_SKIP_PRECOMPILE_HOOK documentation (#852)3b3e3c9Update spec/dummy lockfiles after releaseDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditionsYou can disable automated security fix PRs for this repo from the Security Alerts page.