Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #165 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 32 32
Lines 1393 1393
Branches 240 240
=========================================
Hits 1393 1393 ☔ View full report in Codecov by Sentry. |
benoit74
left a comment
There was a problem hiding this comment.
Nothing much to add, aside from the fact that I don't know if we want to merge this now since you mentioned it is not sufficiently tested.
That been said, it is quite "external", so I don't mind much if we merge this now and add tests later on. It is not included in coverage report anyway ^^
|
There is no real need for this so it can await its tests ; I'd love to complete (or someone else) the missing features and add a workflow that builds an independent static binary as well (just to annoy @kelson42!) @kelson42 what is the purpose of the The way I understand it is that when adding files, all files which extension is considered HTML are decompressed as if those would be zip(zlib)-encoded in-place and if that fails, the raw content is added instead. I'm curious to know what scenario lead to this ugly thing 🙃 |
Here's a first shot at an implementation of zimwriterfs using scraperlib.
It uses the same interface except for two missing features:
--inflateHtml: now sure it's useful at all--skip-libmagic-check: didn't seem worth the effort for a first versionVery little code here, it's mostly CLI. I did not use
make_zim_file()so we can set those creator options that zimwriterfs allows to set…WARN: dumping this so it's not lost but not sure it's ready (haven't written any test yet)