Fix incorrect use of PEX_PYTHON. (cherry-pick of #22994)
#23006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was established in pantsbuild#18433 and only worked due to a Pex bug that unconditionally stripped `PEX_PYTHON` on PEX boot. the portions of pantsbuild#18433 related to the cleanup so described are reverted: > Additionally when making this change, the Python/pex code was > refactored so that we always use this Python to run pex, with Python > either being chosen by pex, or by using PEX_PYTHON env var at > runtime. I think this is a nice cleanup of the handshake between > CompletePexEnvironment.create_argv and > CompletePexEnvironment.environment_dict used to have. Fixes pantsbuild#22988
cburroughs
added
the
release-notes:not-required
Contributor
Author
|
Fails due to this release line being too old and hitting actions/runner-images#13046 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was established in #18433 and only worked due to a Pex bug that unconditionally stripped
PEX_PYTHONon PEX boot. the portions of #18433 related to the cleanup so described are reverted:Fixes #22988