Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 26, 2026

Removes the primer_react_action_list_item_as_button feature flag, which was defaulted to false and served no active purpose. The flag was only used as a test wrapper in stories and tests, not in implementation logic.

Changelog

Removed

  • Feature flag primer_react_action_list_item_as_button from DefaultFeatureFlags
  • FeatureFlags wrappers from ActionList.features.stories.tsx (2 occurrences)
  • FeatureFlags wrapper from NavList.test.tsx
  • Unused FeatureFlags imports from affected files

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

No behavioral changes. Flag was always false and only wrapped test code.

Testing & Reviewing

  • All existing tests pass (2307 tests)
  • Stories render identically without the wrapper
  • Type checking, linting, and formatting all pass

Merge checklist

Original prompt

Create a pull request in primer/react that removes usage and any occurrence of the feature flag or identifier primer_react_action_list_item_as_button across the repository.

Goal

  • Eliminate all references to primer_react_action_list_item_as_button from the codebase, including:
    • Feature flag checks
    • Configuration or enablement code
    • Tests that reference it
    • Documentation or comments mentioning it
    • Any related exports/types/constants
  • Ensure the repository builds, type-checks, lint-checks, and tests pass after removal.

Scope / Hints

  • The repo is a monorepo; primary workspace is packages/react.
  • Search for the string across the repo and remove it everywhere.
  • If the flag gated different behavior, remove the flag logic and keep the intended default behavior (choose the non-flagged path if the flag is no longer supported), adjusting tests accordingly.

Validation

Run and ensure all pass:

  • npm run build
  • npm run type-check
  • npm test
  • npm run lint
  • npm run lint:css
  • npm run format:diff

Notes

  • Update any changelog or release notes if the repo requires it for internal flags removal.

This pull request was created from Copilot chat.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@changeset-bot
Copy link

changeset-bot bot commented Jan 26, 2026

⚠️ No Changeset found

Latest commit: 2c86375

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot AI changed the title [WIP] Remove feature flag primer_react_action_list_item_as_button Remove primer_react_action_list_item_as_button feature flag Jan 26, 2026
Copilot AI requested a review from TylerJDev January 26, 2026 15:16
@TylerJDev TylerJDev marked this pull request as ready for review January 26, 2026 15:32
@TylerJDev TylerJDev requested a review from a team as a code owner January 26, 2026 15:32
Copilot AI review requested due to automatic review settings January 26, 2026 15:32
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jan 26, 2026
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the unused primer_react_action_list_item_as_button feature flag and its remaining test/story wrappers now that it no longer gates any implementation behavior.

Changes:

  • Removed primer_react_action_list_item_as_button from DefaultFeatureFlags.
  • Removed FeatureFlags wrappers (and related imports) from ActionList feature stories.
  • Removed FeatureFlags wrapper (and related import) from the NavList test.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
packages/react/src/FeatureFlags/DefaultFeatureFlags.ts Drops the unused flag from the default flag scope.
packages/react/src/ActionList/ActionList.features.stories.tsx Removes feature-flag wrappers around stories now that the flag is gone.
packages/react/src/NavList/NavList.test.tsx Removes feature-flag wrapper from a test case (and the unused import).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants