-
Notifications
You must be signed in to change notification settings - Fork 647
Remove primer_react_action_list_item_as_button feature flag #7477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Remove primer_react_action_list_item_as_button feature flag #7477
Conversation
|
…base Co-authored-by: TylerJDev <[email protected]>
Co-authored-by: TylerJDev <[email protected]>
|
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Removes the unused primer_react_action_list_item_as_button feature flag and its remaining test/story wrappers now that it no longer gates any implementation behavior.
Changes:
- Removed
primer_react_action_list_item_as_buttonfromDefaultFeatureFlags. - Removed
FeatureFlagswrappers (and related imports) from ActionList feature stories. - Removed
FeatureFlagswrapper (and related import) from the NavList test.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/react/src/FeatureFlags/DefaultFeatureFlags.ts | Drops the unused flag from the default flag scope. |
| packages/react/src/ActionList/ActionList.features.stories.tsx | Removes feature-flag wrappers around stories now that the flag is gone. |
| packages/react/src/NavList/NavList.test.tsx | Removes feature-flag wrapper from a test case (and the unused import). |
Removes the
primer_react_action_list_item_as_buttonfeature flag, which was defaulted tofalseand served no active purpose. The flag was only used as a test wrapper in stories and tests, not in implementation logic.Changelog
Removed
primer_react_action_list_item_as_buttonfromDefaultFeatureFlagsFeatureFlagswrappers fromActionList.features.stories.tsx(2 occurrences)FeatureFlagswrapper fromNavList.test.tsxFeatureFlagsimports from affected filesRollout strategy
No behavioral changes. Flag was always
falseand only wrapped test code.Testing & Reviewing
Merge checklist
Original prompt
This pull request was created from Copilot chat.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.