Make css and className optional for element and elementKeyed#21
Open
jvliwanag wants to merge 1 commit intopurescript-react:mainfrom
Open
Make css and className optional for element and elementKeyed#21jvliwanag wants to merge 1 commit intopurescript-react:mainfrom
jvliwanag wants to merge 1 commit intopurescript-react:mainfrom
Conversation
Member
|
@mjrussell Any chance of this making it in? |
Member
|
Yeah it looks like a good improvement. @jvliwanag do you want to fix the conflicts? |
Member
|
Updating the example for with and without would be super helpful but could be done later |
Member
|
@mjrussell I don't think @jvliwanag really does PS anymore, so we might have to take this over. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18
I can also update the example if need be to remove className and demonstrate it can be used without.