Display commit sha value in the footer.#1558
Open
t-mangoe wants to merge 4 commits intoruby:masterfrom
Open
Conversation
st0012
requested changes
Jan 10, 2026
Member
st0012
left a comment
st0012
left a comment
There was a problem hiding this comment.
Thanks for the attempt. But we don’t want to rely on any dependencies for this feature.
extern-c
reviewed
Jan 24, 2026
lib/rdoc/rdoc.rb
Outdated
|
|
||
| def detect_git_commit | ||
| require "git" | ||
| Git.open(Dir.pwd).object("HEAD").sha |
Contributor
There was a problem hiding this comment.
You could consider using Ruby's Open3.capture3 to run Git commands directly and capture the output you need, instead of relying on the git gem. This can simplify things if you only need to run a single command.
Author
There was a problem hiding this comment.
Thanks!! @extern-c
I changed the code to use Open3.capture3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit SHA value is displayed in the footer. The value is retrieved using the Git gem.
This pull request relates to issue #1475.