Remove features "nightly", "small_rng"; remove old deprecated code#1732
Merged
Remove features "nightly", "small_rng"; remove old deprecated code#1732
Conversation
dhardy
changed the title
dhardy
force-pushed
the
push-ukptzvsszylo
branch
from
e25260b to
410bc26
Compare
dhardy
force-pushed
the
push-ukptzvsszylo
branch
from
410bc26 to
74fa1b4
Compare
dhardy
changed the title
newpavlov
approved these changes
Feb 4, 2026
| ### Removals | ||
| - Removed `ReseedingRng` ([#1722]) | ||
| - Removed unused feature "nightly" ([#1732]) | ||
| - Removed feature `small_rng` ([#1732]) |
Member
There was a problem hiding this comment.
Mention removed deprecated items.
Member
Author
There was a problem hiding this comment.
The removal (or rename) was mentioned previously, so I don't see the need.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdentryThis feature is unused.
Old deprecated code (from v0.9.0) is removed. More recently deprecations have never been published (though "since" said 0.9.2, the changes have not yet been published), hence I bumped the "since" version to 0.10.0.
Removes the "small_rng" feature since I can't think of a single reason to keep it. (Marginally faster builds?) I tested the size of
examples/monte-carlo.rswith/without this, and in debug builds disabling the feature saved 16B (of ~5MiB) while release builds saved 0B (using themoldlinker). (See also #1419.)