-
-
Notifications
You must be signed in to change notification settings - Fork 655
Support React 18+ in peerDeps #3339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
📝 WalkthroughWalkthroughUpdated package configuration to add explicit devDependencies for React 19.2.4 and broaden peerDependencies for Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@packages/react/package.json`:
- Around line 50-51: The peer/dependency mismatch: package.json currently claims
support for "react" and "react-dom" "^17 || ^18 || ^19" while devDependencies
contain "@testing-library/react" v16 which requires React 18+, blocking React 17
testing; fix by either (A) changing devDependencies to "@testing-library/react"
v14 (or another 17-compatible release) and keep the current peerDependencies, or
(B) removing React 17 from the peerDependencies if you no longer intend to
support it—update the package.json entries for "devDependencies" and
"peerDependencies" accordingly (look for symbols "@testing-library/react",
"react", "react-dom", "devDependencies", "peerDependencies"); additionally add a
CI job matrix in the repository workflow (e.g., in your GitHub Actions workflow)
to run the test matrix across React 17, 18, and 19 so tests are validated for
each combination before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@packages/react/package.json`:
- Around line 50-51: Update the PR title and description to accurately state
supported React versions: change any "Support React 17+" wording to "Support
React 18 and 19" (or "Support React 18+" if you prefer broader phrasing) to
match the peerDependencies entries "react" and "react-dom" which are set to
"^18.0.0 || ^19.0.0" and to reflect the `@testing-library/react` v16 requirement;
ensure both the PR title and body consistently mention React 18/19 support so
they align with the package.json declarations.
| "react": "^18.0.0 || ^19.0.0", | ||
| "react-dom": "^18.0.0 || ^19.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR title/description mismatch: actual support is React 18+, not React 17+.
The peerDependencies now correctly support React 18 and 19, which resolves the original issue #3102 (React 19 installation failure). However, the PR title claims "Support React 17+" while the implementation only supports ^18.0.0 || ^19.0.0.
Consider updating the PR title/description to accurately reflect "Support React 18 and 19" to avoid user confusion. This is especially relevant since the @testing-library/react v16 dependency (line 37) requires React 18+, making React 17 support impractical without additional changes.
🤖 Prompt for AI Agents
In `@packages/react/package.json` around lines 50 - 51, Update the PR title and
description to accurately state supported React versions: change any "Support
React 17+" wording to "Support React 18 and 19" (or "Support React 18+" if you
prefer broader phrasing) to match the peerDependencies entries "react" and
"react-dom" which are set to "^18.0.0 || ^19.0.0" and to reflect the
`@testing-library/react` v16 requirement; ensure both the PR title and body
consistently mention React 18/19 support so they align with the package.json
declarations.
Closes #3102
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.