Skip to content

Conversation

@RobbieTheWagner
Copy link
Member

@RobbieTheWagner RobbieTheWagner commented Jan 28, 2026

Closes #3102

Summary by CodeRabbit

  • Chores
    • Broadened React peer compatibility to support React 18 and 19 (wider version range).
    • Added explicit React 19 dev dependencies for development and testing.

✏️ Tip: You can customize this high-level summary in your review settings.

@vercel
Copy link

vercel bot commented Jan 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
shepherd-docs Ready Ready Preview, Comment Jan 28, 2026 10:03pm
1 Skipped Deployment
Project Deployment Review Updated (UTC)
shepherd-landing Skipped Skipped Jan 28, 2026 10:03pm

Request Review

@coderabbitai
Copy link

coderabbitai bot commented Jan 28, 2026

📝 Walkthrough

Walkthrough

Updated package configuration to add explicit devDependencies for React 19.2.4 and broaden peerDependencies for react and react-dom to accept ^17.0.0 || ^18.0.0 || ^19.0.0. No public API or exported declarations changed.

Changes

Cohort / File(s) Summary
Package Configuration
packages/react/package.json
Added react and react-dom devDependencies set to ^19.2.4; expanded peerDependencies from ^18.2.0 to `^17.0.0

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A small hop to nineteen so bright,
Dev deps set and peers now take flight,
I nibble at versions, align every line,
Flutter of whiskers—dependencies fine! 🥕✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The PR title 'Support React 18+ in peerDeps' aligns with the main change (broadening peerDependencies), but the title claims React 18+ support while the objectives state the goal is React 17+ support, creating a discrepancy. Clarify whether the intent is React 17+ or React 18+ support. If React 17+ is intended, update the title to 'Support React 17+ in peerDeps' to match the objectives.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed The PR broadens peerDependencies to support React 18+ and 19+ as shown in package.json changes, directly addressing issue #3102's requirement for React 19 compatibility.
Out of Scope Changes check ✅ Passed All changes are scoped to package.json dependency declarations, which are directly related to the objective of broadening React version support.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@packages/react/package.json`:
- Around line 50-51: The peer/dependency mismatch: package.json currently claims
support for "react" and "react-dom" "^17 || ^18 || ^19" while devDependencies
contain "@testing-library/react" v16 which requires React 18+, blocking React 17
testing; fix by either (A) changing devDependencies to "@testing-library/react"
v14 (or another 17-compatible release) and keep the current peerDependencies, or
(B) removing React 17 from the peerDependencies if you no longer intend to
support it—update the package.json entries for "devDependencies" and
"peerDependencies" accordingly (look for symbols "@testing-library/react",
"react", "react-dom", "devDependencies", "peerDependencies"); additionally add a
CI job matrix in the repository workflow (e.g., in your GitHub Actions workflow)
to run the test matrix across React 17, 18, and 19 so tests are validated for
each combination before merging.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@packages/react/package.json`:
- Around line 50-51: Update the PR title and description to accurately state
supported React versions: change any "Support React 17+" wording to "Support
React 18 and 19" (or "Support React 18+" if you prefer broader phrasing) to
match the peerDependencies entries "react" and "react-dom" which are set to
"^18.0.0 || ^19.0.0" and to reflect the `@testing-library/react` v16 requirement;
ensure both the PR title and body consistently mention React 18/19 support so
they align with the package.json declarations.

Comment on lines +50 to +51
"react": "^18.0.0 || ^19.0.0",
"react-dom": "^18.0.0 || ^19.0.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

PR title/description mismatch: actual support is React 18+, not React 17+.

The peerDependencies now correctly support React 18 and 19, which resolves the original issue #3102 (React 19 installation failure). However, the PR title claims "Support React 17+" while the implementation only supports ^18.0.0 || ^19.0.0.

Consider updating the PR title/description to accurately reflect "Support React 18 and 19" to avoid user confusion. This is especially relevant since the @testing-library/react v16 dependency (line 37) requires React 18+, making React 17 support impractical without additional changes.

🤖 Prompt for AI Agents
In `@packages/react/package.json` around lines 50 - 51, Update the PR title and
description to accurately state supported React versions: change any "Support
React 17+" wording to "Support React 18 and 19" (or "Support React 18+" if you
prefer broader phrasing) to match the peerDependencies entries "react" and
"react-dom" which are set to "^18.0.0 || ^19.0.0" and to reflect the
`@testing-library/react` v16 requirement; ensure both the PR title and body
consistently mention React 18/19 support so they align with the package.json
declarations.

@RobbieTheWagner RobbieTheWagner changed the title Support React 17+ in peerDeps Support React 18+ in peerDeps Jan 29, 2026
@RobbieTheWagner RobbieTheWagner merged commit 1fa78a5 into main Jan 29, 2026
7 checks passed
@RobbieTheWagner RobbieTheWagner deleted the broaden-react-support branch January 29, 2026 10:41
@github-actions github-actions bot mentioned this pull request Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

React 19 Support

2 participants