fix: use correct docker.sock binding with vector (fixes #3593)#4791
Open
unlair wants to merge 1 commit intosupabase:developfrom
Open
fix: use correct docker.sock binding with vector (fixes #3593)#4791unlair wants to merge 1 commit intosupabase:developfrom
unlair wants to merge 1 commit intosupabase:developfrom
Conversation
unlair
force-pushed
the
fix/3593-docker-socket-binding
branch
from
7e6a5e6 to
bc2752d
Compare
…upabase#3593) This fixes Docker Desktop on Linux failing to start the vector container. The container tries to bind to the Docker Desktop socket directly, which is unsupported. The host binding path should always be /var/run/docker.sock, which has special handling under the hood (see docker/for-mac#6545 (comment)).
unlair
force-pushed
the
fix/3593-docker-socket-binding
branch
from
bc2752d to
7368ff6
Compare
Pull Request Test Coverage Report for Build 21680537186Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes Docker Desktop on Linux failing to start the vector container. The container tries to bind to the Docker Desktop socket directly, which is unsupported. This fix closes #3593.
What kind of change does this PR introduce?
Bug fix.
What is the current behavior?
When using Docker Desktop on Linux, Vector fails to start when doing
supabase start.What is the new behavior?
When using Docker Desktop on Linux, Vector successfully starts when doing
supabase start.Additional context
Using Docker or Docker Desktop on Linux, the specified host binding path to the Docker socket should be
/var/run/docker.sock, as that path has special handling under the hood (see docker/for-mac#6545 (comment)). Note that it does not directly use the socket sitting at/var/run/docker.sockon the host machine. My understanding is that what it ends up doing under the hood is essentially using what you get with/var/run/docker.sock.rawfrom outside Docker, as mentioned here: https://docs.docker.com/extensions/extensions-sdk/guides/use-docker-socket-from-backend/