Open
Conversation
… across components
🦋 Changeset detectedLatest commit: c1a9c15 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
commit: |
…te.ts, but will refine further into chart.svelte.ts soon.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals
tooltipState.dataandtooltipState.payloadseriesproporientationtoChart(if needed)?valueAxisdue to inverted orientation meaning in LineChart/BarChartseriesStateoncontextChartStategeoContext/brushContext/tooltipContexttogeoState/ etc<GeoContext bind:geoContext>to<GeoContext bind:state>(and BrushContext, TooltipContext, TransformContext)GeoStateetc withinChart/ChartState?ReplacegetGeoContextwithgetChartContextand usectx.geogetGeoContextfor overrides such as a translucent globeGeoContext/ etc? (if it doesn't have any pointer events / elements)Chart. Simplified and renamedGeoContexttoGeoProjection$effect()logic inGeoContexttoGeoState<BarChart seriesLayout="group">regression (before this PR)createLegendProps()and handle directly sincectx.seriesStateis availableChartAnnotationsto usectx.seriesStateDefaultTooltipto usectx.seriesStateTransformStatehandle pointer eventsonPointerMove, etc or withinTransformContexttooltipContextprops (Arc, GeoPath, etc) totooltipState(or justtooltip)?tooltipMetaContext(consolidate payload, etc)Verify
To fix
x0/y0to0by default #666stroke-current#661dataprop #529SeriesStatefor simplified charts #487related:
SeriesStatefor simplified charts #487