Updated NVAPI detector to add ExtraData in the result if vefied secre… #4668
+228
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
amanfcp
reviewed
Jan 15, 2026
Contributor
There was a problem hiding this comment.
The general purpose of ExtraData is to add information that is helpful for the credentials identification rather than user identification. Credentials type, rotation guide, detector version are some examples.
Here are some examples, rotation guide, key type
Contributor
|
Reopening this -- I was not aware of the context of this PR |
camgunz
approved these changes
Jan 16, 2026
nabeelalam
approved these changes
Jan 19, 2026
shahzadhaider1
approved these changes
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds ExtraData to the results of NVAPI detector. It includes user type of the secret, user-name, email, Orgs and Org-Roles associated with the secret.
Checklist:
make test-community)?make lintthis requires golangci-lint)?