Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/detectors/detectors.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ type Detector interface {
// FromData will scan bytes for results and optionally verify them.
//
// FromData can be called concurrently from multiple goroutines.
// Any modification to the receiver or to global variables will need to to use some kind of synchronization.
// Any modification to the receiver or to global variables will need to use some kind of synchronization.
FromData(ctx context.Context, verify bool, data []byte) ([]Result, error)

// Keywords are used for efficiently pre-filtering chunks using substring operations.
Expand Down
2 changes: 1 addition & 1 deletion pkg/detectors/jwt/jwt.go
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ func (s Scanner) FromData(ctx context.Context, verify bool, data []byte) (result
case "HS256", "HS384", "HS512":
// The JWT *might* be valid, but we can't in general do signature verification on HMAC-based algorithms.
// We don't have a suitable status to represent this situation in trufflehog.
// (The `unknown` status is intended to indicate that an error occurred to to external environment conditions, like trannsient network errors.)
// (The `unknown` status is intended to indicate that an error occurred due to external environmental conditions, like transient network errors.)
// So instead, to avoid possible false positives, totally skip HMAC-based JWTs; don't even create results for them.
continue
}
Expand Down
Loading