Skip to content

Conversation

@gjtorikian
Copy link
Contributor

Summary

  • Adds rake as a development dependency in the gemspec
  • Updates Gemfile.lock to include rake

The rubygems/release-gem@v1 action runs bundle exec rake release, which requires rake to be in the bundle. This was missing, causing the v5.31.1 publish to RubyGems to fail.

Test plan

  • Verify rake is added to gemspec
  • Verify Gemfile.lock includes rake
  • Merge this PR to trigger the release workflow and publish v5.31.1 to RubyGems

🤖 Generated with Claude Code

The rubygems/release-gem action requires rake to be in the bundle
since it runs `bundle exec rake release`. This was missing, which
caused the v5.31.1 publish to RubyGems to fail.

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@gjtorikian gjtorikian requested a review from a team as a code owner February 2, 2026 19:21
@gjtorikian gjtorikian requested review from ericroberts and removed request for a team February 2, 2026 19:21
@greptile-apps
Copy link

greptile-apps bot commented Feb 2, 2026

Greptile Overview

Greptile Summary

This PR adds rake as a development dependency to fix the RubyGems release workflow. The rubygems/release-gem@v1 action executes bundle exec rake release, which previously failed because rake wasn't declared in the gemspec's development dependencies.

Changes:

  • Added rake development dependency in workos.gemspec (line 28) without version constraint, matching the existing pattern used for webmock
  • Updated Gemfile.lock to include rake 13.3.1 in both the GEM specs and DEPENDENCIES sections

This is a minimal, focused fix that resolves the v5.31.1 release failure and will allow future releases to succeed.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change is a simple, well-justified addition of a missing development dependency required by the release workflow. No runtime code is affected, and the change follows existing project conventions.
  • No files require special attention

Important Files Changed

Filename Overview
workos.gemspec Added rake as development dependency without version constraint, consistent with existing webmock dependency
Gemfile.lock Updated lockfile to include rake 13.3.1 in gems and dependencies sections

Sequence Diagram

sequenceDiagram
    participant PR as Pull Request Merge
    participant GH as GitHub Actions
    participant Bundle as Bundler
    participant RG as RubyGems Action
    participant Pub as RubyGems.org

    PR->>GH: Trigger release workflow
    GH->>GH: Create GitHub Release
    GH->>Bundle: bundle install
    Note over Bundle: rake now included<br/>in development dependencies
    Bundle-->>GH: Dependencies installed
    GH->>GH: bundle exec rspec (tests)
    GH->>GH: gem build workos.gemspec
    GH->>RG: rubygems/release-gem@v1
    Note over RG: Runs bundle exec rake release<br/>which requires rake to be in bundle
    RG->>Pub: Publish gem to RubyGems.org
    Pub-->>RG: Success

Loading

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@gjtorikian gjtorikian merged commit 678e1d5 into main Feb 3, 2026
5 of 20 checks passed
@gjtorikian gjtorikian deleted the add-rake-dependency branch February 3, 2026 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants